Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor console kernel bootstrapper loading #1771

Merged
merged 10 commits into from
Jul 1, 2024

Conversation

caendesilva
Copy link
Member

Picks up where #1770 left off

I think adding a dedicated environment configuration loader to get data from the Yaml file could work if it's in between the environment and configuration loaders

Copy link

codecov bot commented Jul 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (b14d20b) to head (ce1ea52).
Report is 1 commits behind head on master.

Current head ce1ea52 differs from pull request most recent head d9080cc

Please upload reports for the commit d9080cc to get more accurate results.

Additional details and impacted files
@@             Coverage Diff             @@
##              master     #1771   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity      1758      1758           
===========================================
  Files            180       180           
  Lines           4689      4694    +5     
===========================================
+ Hits            4689      4694    +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@caendesilva caendesilva merged commit 034b151 into master Jul 1, 2024
39 checks passed
@caendesilva caendesilva deleted the improve-yaml-environment-configuration-loading branch July 1, 2024 14:22
@caendesilva
Copy link
Member Author

Okay, GitHub glitched and merged this when merging the cherry picked PR...

@caendesilva caendesilva changed the title Improve Yaml environment configuration loading Refactor console kernel bootstrapper loading Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant