Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to massively simplify internal route list helper classes #1679

Merged

Conversation

caendesilva
Copy link
Member

This is not meant to be extended, so we don't need to contract the helpers

This is not meant to be extended, so we don't need to contract the helpers
Copy link

codecov bot commented Apr 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.97%. Comparing base (78e9b0d) to head (9e01e0a).
Report is 1 commits behind head on master.

❗ Current head 9e01e0a differs from pull request most recent head f9a80ad. Consider uploading reports for the commit f9a80ad to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1679      +/-   ##
============================================
- Coverage     99.97%   99.97%   -0.01%     
- Complexity     1743     1744       +1     
============================================
  Files           182      181       -1     
  Lines          4669     4663       -6     
============================================
- Hits           4668     4662       -6     
  Misses            1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@caendesilva caendesilva force-pushed the refactor-to-move-internal-code-to-internal-namespace branch from 9b2c62d to cebe636 Compare April 25, 2024 18:10
@caendesilva caendesilva marked this pull request as ready for review April 25, 2024 20:29
@caendesilva caendesilva merged commit dd83299 into master Apr 25, 2024
20 checks passed
@caendesilva caendesilva deleted the refactor-to-move-internal-code-to-internal-namespace branch April 25, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant