Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip sitemap generation when there is no valid base URL #1660

Merged
merged 3 commits into from
Apr 13, 2024
Merged

Skip sitemap generation when there is no valid base URL #1660

merged 3 commits into from
Apr 13, 2024

Commits on Apr 13, 2024

  1. Skip sitemap generation when there is no valid base URL 

    Before, this would fall back to a relative URL, but these no longer validate by Google and will not be indexed. It feels a bit dramatic to have an exception be thrown when building test sites locally so instead we just skip the build, but with a helpful message.
    @caendesilva
    caendesilva committed Apr 13, 2024
    Configuration menu
    Copy the full SHA
    9bfffc8 View commit details
    Browse the repository at this point in the history

  2. Update test to set base URL

    @caendesilva
    caendesilva committed Apr 13, 2024
    Configuration menu
    Copy the full SHA
    7c6393b View commit details
    Browse the repository at this point in the history

  3. Update RELEASE_NOTES.md

    @caendesilva
    caendesilva committed Apr 13, 2024
    Configuration menu
    Copy the full SHA
    20f5002 View commit details
    Browse the repository at this point in the history