[2.x] Extract trait for shared code with navigation menu class #1630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## simplify-public-navigation-apis #1630 +/- ##
==================================================================
Coverage 99.97% 99.97%
Complexity 1779 1779
==================================================================
Files 184 184
Lines 4800 4800
==================================================================
Hits 4799 4799
Misses 1 1 ☔ View full report in Codecov by Sentry. |
|
The implementations are quite different actually, with the grouped navigation items being stored as an array. Refactoring this isn't worth the complexity, instead I think it's better to simplify the API of the grouped item class. |
|
Reopening trying to target #1642 instead |
caendesilva
force-pushed
the
restructure-navigation-item-oop-design
branch
from
4631a96
to
62d6930
Compare
caendesilva
changed the base branch from
improved-navigation-internals
to
simplify-public-navigation-apis
caendesilva
force-pushed
the
restructure-navigation-item-oop-design
branch
from
6dd2970
to
bccde3d
Compare
|
Partially reverted by #1645 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.