[2.x] Create HTML tests for the navigation layouts #1605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## improved-navigation-internals #1605 +/- ##
================================================================
Coverage 99.95% 99.95%
Complexity 1778 1778
================================================================
Files 184 184
Lines 4809 4809
================================================================
Hits 4807 4807
Misses 2 2 ☔ View full report in Codecov by Sentry. |
caendesilva
force-pushed
the
create-navigation-html-layouts-test
branch
from
0d0751a
to
59b6547
Compare
caendesilva
force-pushed
the
create-navigation-html-layouts-test
branch
from
02c9f91
to
4736541
Compare
Just want cleaner diffs for now
caendesilva
force-pushed
the
create-navigation-html-layouts-test
branch
from
52d4892
to
69453a6
Compare
caendesilva
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds another test for #1568. This might be slightly overkill, but considering how important these features are, it's nice to have high level visual-style tests that can signal smoke before end-to-end testing kicks in (as that is painfully slow).