Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved view testing #1588

Merged
merged 20 commits into from
Feb 24, 2024
Merged

Improved view testing #1588

merged 20 commits into from
Feb 24, 2024

Conversation

caendesilva
Copy link
Member

@caendesilva caendesilva commented Feb 24, 2024

Adds some testing helpers and a new test. This PR is considered internal since it only affects the test suite and no public code.

@caendesilva
Copy link
Member Author

Realized/remembered that Laravel brings view testing features. I don't think they're 100% the best, so am going to change this to make some improvements to the existing ones.

Copy link

codecov bot commented Feb 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (0864ef1) to head (d190704).

Additional details and impacted files
@@              Coverage Diff              @@
##              master     #1588     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
- Complexity      1746      3492   +1746     
=============================================
  Files            180       360    +180     
  Lines           4723      9446   +4723     
=============================================
+ Hits            4723      9446   +4723     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@caendesilva caendesilva marked this pull request as ready for review February 24, 2024 17:58
@caendesilva caendesilva merged commit 1ec4ca5 into master Feb 24, 2024
19 checks passed
@caendesilva caendesilva deleted the improved-view-testing branch February 24, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant