[2.x] Split out base navigation menu class from main menu class #1580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caendesilva
force-pushed
the
refactor-navigation-menu-container-bindings
branch
from
b935730
to
ac4e689
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## improved-navigation-internals #1580 +/- ##
=================================================================
Coverage 100.00% 100.00%
+ Complexity 1759 1758 -1
=================================================================
Files 183 183
Lines 4758 4756 -2
=================================================================
- Hits 4758 4756 -2 ☔ View full report in Codecov by Sentry. |
caendesilva
force-pushed
the
refactor-navigation-menu-container-bindings
branch
from
9ccc1a2
to
7f9b0c6
Compare
caendesilva
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Targets v2.x via #1568
See #1568 (review)