Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the semantic documentation article Blade view #1506

Merged
merged 3 commits into from
Dec 23, 2023

Conversation

caendesilva
Copy link
Member

@caendesilva caendesilva commented Dec 23, 2023

Changes

Renames the local template variable $document to $article to better match the usage

  • This also makes it more inline with the $article used by blog posts.

Updates documentation article component to support existing variables

  • Allows for them to be passed from a model class, for example.

Copy link

codecov bot commented Dec 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8d24f57) 100.00% compared to head (2f07b97) 100.00%.

Additional details and impacted files
@@              Coverage Diff              @@
##              master     #1506     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
- Complexity      1740      3480   +1740     
=============================================
  Files            180       360    +180     
  Lines           4715      9430   +4715     
=============================================
+ Hits            4715      9430   +4715     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Allows for them to be passed from a model class, for example.
@caendesilva caendesilva force-pushed the improve-semantic-documentation-article-view branch from 94c45a2 to 4f9464d Compare December 23, 2023 12:00
Allows for them to be passed from a model class, for example.
@caendesilva caendesilva marked this pull request as ready for review December 23, 2023 12:06
@caendesilva caendesilva merged commit a26c7da into master Dec 23, 2023
19 checks passed
@caendesilva caendesilva deleted the improve-semantic-documentation-article-view branch December 23, 2023 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant