Pass through settings to the realtime compiler #1450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1450 +/- ##
=============================================
Coverage 100.00% 100.00%
- Complexity 1719 3456 +1737
=============================================
Files 180 360 +180
Lines 4662 9386 +4724
=============================================
+ Hits 4662 9386 +4724
|
caendesilva
force-pushed
the
pass-through-settings-to-realtime-compiler
branch
from
e0b3b8d
to
e65d191
Compare
caendesilva
force-pushed
the
pass-through-settings-to-realtime-compiler
branch
from
a94786a
to
3fe6ad8
Compare
caendesilva
force-pushed
the
pass-through-settings-to-realtime-compiler
branch
from
586c159
to
52571f6
Compare
caendesilva
force-pushed
the
pass-through-settings-to-realtime-compiler
branch
from
249cc2f
to
03ef853
Compare
caendesilva
force-pushed
the
pass-through-settings-to-realtime-compiler
branch
from
4b0cf09
to
586cf18
Compare
Does not change rendered output
caendesilva
force-pushed
the
pass-through-settings-to-realtime-compiler
branch
from
47b57e1
to
401c78b
Compare
Just saves on testing logic as we can fix the version
caendesilva
force-pushed
the
pass-through-settings-to-realtime-compiler
branch
from
8435e1e
to
e666159
Compare
This reverts commit b1b155e.
This just feels bloaty at the moment, plus the user should be able to assume that the flag they provided is applied.
caendesilva
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a few new options to the
php hyde servecommand to allow some settings to be specified with command-line options. This is done by creating environment variables passed through to the Symfony process, and which are then injected into the configuration repository by our custom runtime configuration loader originally used for Yaml configuration. This makes so that the options are fully integrated into the request lifecycle. Also cleans up some adjacent code.