Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle old todo markers in codebase #1442

Merged
merged 3 commits into from
Nov 8, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/deploy-documentation-preview.yml
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,6 @@ jobs:
run: rm resources/views/vendor/hyde/components/docs/documentation-article.blade.php

- name: Create component to add an information badge
# TODO 1. Extract to component. 2. Add feature to hide card which is stored in local session storage for the duration of the visit (so it's reset on next PR page visit)
run: |
mkdir -p resources/views/vendor/hyde/layouts
cp vendor/hyde/framework/resources/views/layouts/docs.blade.php resources/views/vendor/hyde/layouts/docs.blade.php
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ protected function getLinesFromInputStream(): array

protected function shouldTerminate(string $line): bool
{
// TODO add option to terminate with two blank lines (useful for tags input, but is default to false, for example to accept paragraphs)
// We could add an option to terminate with two blank lines (useful for tags input, but is default to false, for example to accept paragraphs)

return $line === self::TERMINATION_SEQUENCE || str_contains($line, self::END_OF_TRANSMISSION);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ protected function handleEmptyMediaFilesCollection(PublicationFieldDefinition $f
$this->newLine();
$this->warn("<fg=red>Warning:</> No media files found in $directory");
if ($this->confirm('Would you like to skip this field?', true)) {
// TODO We could have a choice here, where 0 skips, and 1 reloads the media files
// We could have a choice here, where 0 skips, and 1 reloads the media files
return null;
} else {
throw new InvalidArgumentException('Unable to locate any media files for this publication type');
Expand Down
3 changes: 2 additions & 1 deletion packages/publications/src/Concerns/PublicationFieldTypes.php
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,8 @@ enum PublicationFieldTypes: string
case Array = 'array';
case Media = 'media';
case Text = 'text';
case Tag = 'tag'; // TODO: Rename to "tags"?
/** @deprecated May be renamed to Tags to better fit usage */
case Tag = 'tag';
case Url = 'url';

/** Get the default validation rules for this field type. */
Expand Down
Loading