Additional minor code quality and type improvements #1414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1414 +/- ##
=============================================
Coverage 100.00% 100.00%
- Complexity 1706 3416 +1710
=============================================
Files 180 360 +180
Lines 4621 9268 +4647
=============================================
+ Hits 4621 9268 +4647
|
This will allow us to resolve types from items retrieved from the Laravel service container.
This reverts commit d9285a9 as plugin for some reason breaks Illuminate.
caendesilva
force-pushed
the
code-quality
branch
4 times, most recently
from
9e873d1
to
a0543ec
Compare
caendesilva
force-pushed
the
code-quality
branch
2 times, most recently
from
05c74a9
to
8e560b3
Compare
This reverts commit 6a9da4a8200b9666559fd1c4b3031d8d559b5eec due to broken plugin.
caendesilva
force-pushed
the
code-quality
branch
from
8e560b3
to
d76aa3a
Compare
Uses the generics from the vendor source code
Same semantics, but maybe a little more readable
caendesilva
changed the title
caendesilva
force-pushed
the
code-quality
branch
from
8caa925
to
c9d6bf7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleans up code and brings up type coverage by another
~0.25%