Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add runtime configuration option for the --no-api build flag #1412

Merged
merged 3 commits into from
Oct 28, 2023
Merged

Add runtime configuration option for the --no-api build flag #1412

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fffee0a
Add runtime configuration option for `--no-api` build flag
caendesilva Oct 28, 2023
f6290ac
Merge branch 'master' into set-build-flag-in-runtime-configuration
caendesilva Oct 28, 2023
492da4a
Merge branch 'master' into set-build-flag-in-runtime-configuration
caendesilva Oct 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/framework/src/Foundation/Internal/LoadConfiguration.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,11 @@ private function loadRuntimeConfiguration(Application $app, RepositoryContract $
if (in_array('--pretty-urls', $_SERVER['argv'], true)) {
$repository->set('hyde.pretty_urls', true);
}

// Check if the `--no-api` CLI argument is set, and if so, set the config value accordingly.
if (in_array('--no-api', $_SERVER['argv'], true)) {
$repository->set('hyde.api_calls', false);
}
}
}
}
3 changes: 1 addition & 2 deletions packages/framework/src/Framework/Features/Blogging/Models/FeaturedImage.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
use Hyde\Framework\Exceptions\FileNotFoundException;
use Hyde\Markdown\Contracts\FrontMatter\SubSchemas\FeaturedImageSchema;

use function in_array;
use function array_key_exists;
use function array_flip;
use function file_exists;
Expand Down Expand Up @@ -226,7 +225,7 @@ protected function getContentLengthForLocalImage(): int
protected function getContentLengthForRemoteImage(): int
{
// Check if the --no-api flag is set when running the build command, and if so, skip the API call.
if (! (isset($_SERVER['argv']) && in_array('--no-api', $_SERVER['argv'], true))) {
if (Config::getBool('hyde.api_calls', true)) {
$headers = Http::withHeaders([
'User-Agent' => Config::getString('hyde.http_user_agent', 'RSS Request Client'),
])->head($this->getSource())->headers();
Expand Down
4 changes: 3 additions & 1 deletion packages/framework/tests/Unit/LoadConfigurationTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,18 +17,20 @@ public function testItLoadsRuntimeConfiguration()
{
$serverBackup = $_SERVER;

$_SERVER['argv'] = ['--pretty-urls'];
$_SERVER['argv'] = ['--pretty-urls', '--no-api'];

$app = new Application(getcwd());

$loader = new LoadConfiguration();
$loader->bootstrap($app);

$this->assertTrue(config('hyde.pretty_urls'));
$this->assertFalse(config('hyde.api_calls'));

$_SERVER = $serverBackup;

$loader->bootstrap($app);
$this->assertFalse(config('hyde.pretty_urls'));
$this->assertNull(config('hyde.api_calls'));
}
}
Loading