Break down complex command class helper method #1397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method has high cyclomatic complexity. Extracting additional helper methods reduces the scope of method.
Codecov Report
@@ Coverage Diff @@
## master #1397 +/- ##
===========================================
Coverage 99.97% 99.97%
- Complexity 1703 3410 +1707
===========================================
Files 180 360 +180
Lines 4615 9238 +4623
===========================================
+ Hits 4614 9236 +4622
- Misses 1 2 +1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method has high cyclomatic complexity. Extracting additional helper methods reduces the scope of method.