Improves how the site output directory is emptied, helping prevent accidental deletion of files #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hydephp/develop into improve-build-directory-purging
Codecov Report
@@ Coverage Diff @@
## master #135 +/- ##
=========================================
Coverage 99.23% 99.23%
- Complexity 758 760 +2
=========================================
Files 97 97
Lines 1964 1969 +5
=========================================
+ Hits 1949 1954 +5
Misses 15 15
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First checks if the configured directory is on the whitelist of safe directories (can be configured using
hyde.safe_output_directories, please submit PRs/comments with more ideas for default safe directories!), and asks if the user really wants the directory to be emptied. Defaults to false. Then when it's okay to proceed, the output is emptied using a less nuclear approach to prevent accidental file deletions. Yes, I accidentally deleted my .git directory. And I did so twice. (And the somehow the vendor directory in the CI).