Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for config flags in server globals when loading the configuration #1302

Conversation

caendesilva
Copy link
Member

Updates the custom configuration loader to check for CLI flags in the server globals. This allows us to collect information very early on in the internal application lifecycle. It contains a flag check which fixes #1301

@caendesilva caendesilva linked an issue Mar 15, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Mar 15, 2023

Codecov Report

Merging #1302 (44cb816) into master (bf6fe27) will not change coverage.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##              master     #1302     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
- Complexity      1319      2646   +1327     
=============================================
  Files            152       304    +152     
  Lines           3454      6918   +3464     
=============================================
+ Hits            3454      6918   +3464     
Impacted Files Coverage Δ
...work/src/Foundation/Internal/LoadConfiguration.php 100.00% <100.00%> (ø)

... and 152 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caendesilva caendesilva marked this pull request as ready for review March 15, 2023 14:29
@caendesilva caendesilva merged commit 7be6b59 into master Mar 15, 2023
@caendesilva caendesilva deleted the check-for-config-flags-in-server-globals-when-loading-the-configuration branch March 15, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build-time --pretty-urls flag is not respected by canonical URLs
1 participant