Merge pull request #578 from hydephp/Remove-interface-ActionContract

Remove interface ActionContract.php
hydephp · Oct 25, 2022 · d74bc19 · d74bc19
2 parents 3112d25 + 8ab4780
commit d74bc19
Show file tree

Hide file tree

Showing 7 changed files with 5 additions and 28 deletions.
diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md
@@ -41,6 +41,7 @@ If you however have written custom code that explicitly references the old names
 
 ### Removed
 - Removed MetadataItemContract.php (use new abstract class BaseMetadataElement)
+- Removed interface ActionContract.php
 
 ### Fixed
 - for any bug fixes.

diff --git a/packages/framework/src/Actions/Constructors/FindsContentLengthForImageObject.php b/packages/framework/src/Actions/Constructors/FindsContentLengthForImageObject.php
@@ -2,7 +2,6 @@
 
 namespace Hyde\Framework\Actions\Constructors;
 
-use Hyde\Framework\Contracts\ActionContract;
 use Hyde\Framework\Hyde;
 use Hyde\Framework\Models\Support\Image;
 use Illuminate\Support\Facades\Http;
@@ -12,7 +11,7 @@
 /**
  * @see \Hyde\Framework\Testing\Feature\FindsContentLengthForImageObjectTest
  */
-class FindsContentLengthForImageObject implements ActionContract
+class FindsContentLengthForImageObject
 {
     protected Image $image;
 

diff --git a/packages/framework/src/Actions/GeneratesSidebarTableOfContents.php b/packages/framework/src/Actions/GeneratesSidebarTableOfContents.php
@@ -2,7 +2,6 @@
 
 namespace Hyde\Framework\Actions;
 
-use Hyde\Framework\Contracts\ActionContract;
 use League\CommonMark\Environment\Environment;
 use League\CommonMark\Extension\CommonMark\CommonMarkCoreExtension;
 use League\CommonMark\Extension\HeadingPermalink\HeadingPermalinkExtension;
@@ -14,7 +13,7 @@
  *
  * @see \Hyde\Framework\Testing\Feature\Actions\GeneratesSidebarTableOfContentsTest
  */
-class GeneratesSidebarTableOfContents implements ActionContract
+class GeneratesSidebarTableOfContents
 {
     protected string $markdown;
 

diff --git a/packages/framework/src/Actions/PublishesHomepageView.php b/packages/framework/src/Actions/PublishesHomepageView.php
@@ -2,15 +2,14 @@
 
 namespace Hyde\Framework\Actions;
 
-use Hyde\Framework\Contracts\ActionContract;
 use Hyde\Framework\Hyde;
 
 /**
  * Publish one of the Hyde homepages.
  *
  * @see \Hyde\Framework\Testing\Feature\Actions\PublishesHomepageViewTest
  */
-class PublishesHomepageView implements ActionContract
+class PublishesHomepageView
 {
     public static array $homePages = [
         'welcome' => [

diff --git a/packages/framework/src/Actions/PublishesHydeViews.php b/packages/framework/src/Actions/PublishesHydeViews.php
@@ -2,7 +2,6 @@
 
 namespace Hyde\Framework\Actions;
 
-use Hyde\Framework\Contracts\ActionContract;
 use Hyde\Framework\Hyde;
 use Illuminate\Support\Facades\File;
 
@@ -11,7 +10,7 @@
 *
 * @see \Hyde\Framework\Testing\Feature\Actions\PublishesHomepageViewTest
 */
-class PublishesHydeViews implements ActionContract
+class PublishesHydeViews
 {
     public static array $options = [
         'layouts' => [

diff --git a/packages/framework/src/Contracts/ActionContract.php b/packages/framework/src/Contracts/ActionContract.php
diff --git a/packages/framework/tests/Feature/Actions/PublishesHomepageViewTest.php b/packages/framework/tests/Feature/Actions/PublishesHomepageViewTest.php
@@ -3,7 +3,6 @@
 namespace Hyde\Framework\Testing\Feature\Actions;
 
 use Hyde\Framework\Actions\PublishesHomepageView;
-use Hyde\Framework\Contracts\ActionContract;
 use Hyde\Framework\Hyde;
 use Hyde\Testing\TestCase;
 
@@ -12,11 +11,6 @@
  */
 class PublishesHomepageViewTest extends TestCase
 {
-    public function test_implements_action_contract()
-    {
-        $this->assertInstanceOf(ActionContract::class, new PublishesHomepageView('foo'));
-    }
-
     public function test_home_pages_array_contains_all_available_home_pages()
     {
         $array = PublishesHomepageView::$homePages;