Add rule against use against useless methods in unit tests

monorepo/HydeStan/HydeStan.php

@@ -20,6 +20,7 @@ final class HydeStan
     private const TEST_FILE_ANALYSERS = [
         NoFixMeAnalyser::class,
         NoUsingAssertEqualsForScalarTypesTestAnalyser::class,
+        NoSetUpTearDownInUnitTestCaseAnalyser::class,
     ];
 
     private const LINE_ANALYSERS = [
@@ -382,3 +383,24 @@ public function run(string $file, int $lineNumber, string $line): void
         }
     }
 }
+
+class NoSetUpTearDownInUnitTestCaseAnalyser extends FileAnalyser
+{
+    public function run(string $file, string $contents): void
+    {
+        if (!str_contains($contents, 'extends UnitTestCase')) {
+            return;
+        }
+
+        $methods = ['setUp', 'tearDown'];
+
+        foreach ($methods as $method) {
+            AnalysisStatisticsContainer::analysedExpression();
+            if (preg_match("/function\s+$method\s*\(/", $contents)) {
+                $lineNumber = substr_count(substr($contents, 0, strpos($contents, "function $method")), "\n") + 1;
+                $this->fail(sprintf("Found %s method in UnitTestCase at %s", $method, fileLink($file, $lineNumber)));
+                HydeStan::addActionsMessage('error', $file, $lineNumber, "HydeStan: Unnecessary{$method}MethodError", "{$method} method in UnitTestCase performs no operation and should be removed.");
+            }
+        }
+    }
+}