Merge pull request #1442 from hydephp/code-cleanup

Handle old todo markers in codebase
hydephp · Nov 8, 2023 · c56631e · c56631e
2 parents f71aadf + 42993cd
commit c56631e
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/.github/workflows/deploy-documentation-preview.yml b/.github/workflows/deploy-documentation-preview.yml
@@ -56,7 +56,6 @@ jobs:
         run: rm resources/views/vendor/hyde/components/docs/documentation-article.blade.php
 
       - name: Create component to add an information badge
-        # TODO 1. Extract to component. 2. Add feature to hide card which is stored in local session storage for the duration of the visit (so it's reset on next PR page visit)
         run: |
           mkdir -p resources/views/vendor/hyde/layouts
           cp vendor/hyde/framework/resources/views/layouts/docs.blade.php resources/views/vendor/hyde/layouts/docs.blade.php

diff --git a/packages/publications/src/Commands/Helpers/InputStreamHandler.php b/packages/publications/src/Commands/Helpers/InputStreamHandler.php
@@ -53,7 +53,7 @@ protected function getLinesFromInputStream(): array
 
     protected function shouldTerminate(string $line): bool
     {
-        // TODO add option to terminate with two blank lines (useful for tags input, but is default to false, for example to accept paragraphs)
+        // We could add an option to terminate with two blank lines (useful for tags input, but is default to false, for example to accept paragraphs)
 
         return $line === self::TERMINATION_SEQUENCE || str_contains($line, self::END_OF_TRANSMISSION);
     }

diff --git a/packages/publications/src/Commands/MakePublicationCommand.php b/packages/publications/src/Commands/MakePublicationCommand.php
@@ -171,7 +171,7 @@ protected function handleEmptyMediaFilesCollection(PublicationFieldDefinition $f
         $this->newLine();
         $this->warn("<fg=red>Warning:</> No media files found in $directory");
         if ($this->confirm('Would you like to skip this field?', true)) {
-            // TODO We could have a choice here, where 0 skips, and 1 reloads the media files
+            // We could have a choice here, where 0 skips, and 1 reloads the media files
             return null;
         } else {
             throw new InvalidArgumentException('Unable to locate any media files for this publication type');

diff --git a/packages/publications/src/Concerns/PublicationFieldTypes.php b/packages/publications/src/Concerns/PublicationFieldTypes.php
@@ -25,7 +25,8 @@ enum PublicationFieldTypes: string
     case Array = 'array';
     case Media = 'media';
     case Text = 'text';
-    case Tag = 'tag'; // TODO: Rename to "tags"?
+    /** @deprecated May be renamed to Tags to better fit usage  */
+    case Tag = 'tag';
     case Url = 'url';
 
     /** Get the default validation rules for this field type. */