Make action pagination parameters nullable and shift defaults to there

hydephp · Dec 24, 2022 · 3dba236 · 3dba236
1 parent 3de00f3
commit 3dba236
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 9 deletions.
diff --git a/packages/framework/src/Console/Commands/MakePublicationTypeCommand.php b/packages/framework/src/Console/Commands/MakePublicationTypeCommand.php
@@ -169,7 +169,7 @@ protected function addCreatedAtMetaField(): void
     protected function getPaginationSettings(): array
     {
         if ($this->option('use-defaults') || ! $this->confirm('Do you want to configure pagination settings?')) {
-            return ['__createdAt', true, 25, true];
+            return [null, null, null, null];
         }
 
         return [$this->getSortField(), $this->getSortDirection(), $this->getPageSize(), $this->getPrevNextLinks()];

diff --git a/packages/framework/src/Framework/Actions/CreatesNewPublicationType.php b/packages/framework/src/Framework/Actions/CreatesNewPublicationType.php
@@ -24,10 +24,10 @@ public function __construct(
         protected string $name,
         protected Collection $fields,
         protected string $canonicalField,
-        protected string $sortField,
-        protected bool $sortAscending,
-        protected bool $prevNextLinks,
-        protected int $pageSize,
+        protected ?string $sortField,
+        protected ?bool $sortAscending,
+        protected ?bool $prevNextLinks,
+        protected ?int $pageSize,
         protected ?OutputStyle $output = null,
     ) {
         $this->dirName = $this->formatStringForStorage($this->name);
@@ -42,10 +42,10 @@ protected function handleCreate(): void
             "{$this->dirName}_detail",
             "{$this->dirName}_list",
             [
-                $this->sortField,
-                $this->sortAscending,
-                $this->prevNextLinks,
-                $this->pageSize,
+                $this->sortField ?? '__createdAt',
+                $this->sortAscending ?? true,
+                $this->prevNextLinks ?? true,
+                $this->pageSize ?? 25,
             ],
             $this->fields->toArray()
         );