Forward methods using argument list function to make mocking easier

hydephp · Sep 8, 2024 · 0ae4a02 · 0ae4a02
1 parent 26bfbe1
commit 0ae4a02
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 4 deletions.
diff --git a/packages/framework/src/Facades/Filesystem.php b/packages/framework/src/Facades/Filesystem.php
@@ -113,7 +113,7 @@ public static function unlinkIfExists(string $path): bool
      */
     public static function getContents(string $path, bool $lock = false): string
     {
-        return self::get($path, $lock);
+        return self::get(...func_get_args());
     }
 
     /**
@@ -126,7 +126,7 @@ public static function getContents(string $path, bool $lock = false): string
      */
     public static function putContents(string $path, string $contents, bool $lock = false): bool|int
     {
-        return self::put($path, $contents, $lock);
+        return self::put(...func_get_args());
     }
 
     protected static function filesystem(): \Illuminate\Filesystem\Filesystem

diff --git a/packages/framework/tests/Feature/FilesystemFacadeTest.php b/packages/framework/tests/Feature/FilesystemFacadeTest.php
@@ -80,18 +80,32 @@ public function testUnlinkIfExists()
 
     public function testGetContents()
     {
-        $this->createExpectation('get', 'string', Hyde::path('path'), false);
+        $this->createExpectation('get', 'string', Hyde::path('path'));
 
         Filesystem::getContents('path');
     }
 
+    public function testGetContentsWithLock()
+    {
+        $this->createExpectation('get', 'string', Hyde::path('path'), true);
+
+        Filesystem::getContents('path', true);
+    }
+
     public function testPutContents()
     {
-        $this->createExpectation('put', true, Hyde::path('path'), 'string', false);
+        $this->createExpectation('put', true, Hyde::path('path'), 'string');
 
         Filesystem::putContents('path', 'string');
     }
 
+    public function testPutContentsWithLock()
+    {
+        $this->createExpectation('put', true, Hyde::path('path'), 'string', true);
+
+        Filesystem::putContents('path', 'string', true);
+    }
+
     public function testExists()
     {
         $this->createExpectation('exists', true, Hyde::path('path'));