This repository has been archived by the owner on Mar 15, 2020. It is now read-only.
Use Composer's CA bundle library #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@padraic This would solve our problems with Puli (and I know other projects having troubles too). Do you think it could be merged ? I can work on it to fix tests if needed. |
|
Looks like a nice one, but I would prefer to let someone more familiar on this topic :) /cc @humbug/core |
padraic
approved these changes
Apr 14, 2017
|
Thanks for the PR @thewilkybarkid, sorry for the delay :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Composer has recently extracted their CA bundle logic into a separate library (composer/ca-bundle). Using it fixes #8 as it falls back to a shipped CA file; the point about maintenance still remains, but I imagine if any file is going to be maintained it'd be this one.