Skip to content
This repository has been archived by the owner on Mar 15, 2020. It is now read-only.

test enhancement #22

Merged
merged 5 commits into from
Feb 8, 2018
Merged

test enhancement #22

merged 5 commits into from
Feb 8, 2018

Conversation

peter279k
Copy link
Contributor

Changed log

  • set correct Travis CI setting
  • set the current version for PHPUnit, and PHP.
  • using the vfsStream to mock the file system.
  • add the PHP 7.2 test
  • according to this issue, the PHP 5.3 should set the precise dist when doing Travis CI build.

Copy link
Member

@theofidry theofidry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for that work @peter279k!

I left a few nitpicks, but looks pretty good otherwise. I'll do a release shortly after this is merged

.travis.yml Outdated
@@ -19,7 +22,7 @@ cache:
- $HOME/.composer/cache/files

before_script:
- composer install --no-interaction --prefer-dist
- composer install
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why removing this? I would actually add --no-progress --no-suggest

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean replace --no-progress --no-suggest with --no-interaction --prefer-dist ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No I mean adding it as well, sorry for not being clear enough

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's okay. I will add this options back.

changelog Outdated
@@ -0,0 +1,4 @@
- set correct Travis CI setting
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for a changelog, the releases contains the changelog for now :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops! It's my fault. I will remove this.

@peter279k peter279k changed the title remove build folder test enhancement Feb 8, 2018
@aik099
Copy link

aik099 commented Feb 8, 2018

I wonder why this library needs to be used in PHP 7 and above, where file_get_contents function was already fixed to work with SSL urls?

@theofidry
Copy link
Member

No you don't need it in PHP 7+. It's good to keep the support for it as a lib may be using it and support PHP 5.x and 7.x, but a PHP 7+ only doesn't make sense.

@theofidry theofidry merged commit 50e137d into humbug:master Feb 8, 2018
@theofidry
Copy link
Member

Many thanks @peter279k

@aik099
Copy link

aik099 commented Feb 8, 2018

I see, thanks. I'm kind of CURL guy, never used file system functions to access URLs of any kind.

@peter279k
Copy link
Contributor Author

Sometimes I maintain the old legacy system and need the file_get_contents to handle the HTTP.
And I know the curl (even Guzzle) is better than using this.
Thank you for @theofidry again.

@theofidry
Copy link
Member

Sure, but this allows you to query a URL without having the curl extension or Guzzle installed so it's a pretty good solution for minimal requirements :)

That said I wouldn't recommend to replace all your clients by it, it's for very specific usages.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants