-
Notifications
You must be signed in to change notification settings - Fork 15
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks for that work @peter279k!
I left a few nitpicks, but looks pretty good otherwise. I'll do a release shortly after this is merged
.travis.yml
Outdated
@@ -19,7 +22,7 @@ cache: | |||
- $HOME/.composer/cache/files | |||
|
|||
before_script: | |||
- composer install --no-interaction --prefer-dist | |||
- composer install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why removing this? I would actually add --no-progress --no-suggest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean replace --no-progress --no-suggest
with --no-interaction --prefer-dist
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No I mean adding it as well, sorry for not being clear enough
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's okay. I will add this options back.
changelog
Outdated
@@ -0,0 +1,4 @@ | |||
- set correct Travis CI setting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need for a changelog, the releases contains the changelog for now :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops! It's my fault. I will remove this.
I wonder why this library needs to be used in PHP 7 and above, where |
No you don't need it in PHP 7+. It's good to keep the support for it as a lib may be using it and support PHP 5.x and 7.x, but a PHP 7+ only doesn't make sense. |
Many thanks @peter279k |
I see, thanks. I'm kind of CURL guy, never used file system functions to access URLs of any kind. |
Sometimes I maintain the old legacy system and need the |
Sure, but this allows you to query a URL without having the curl extension or Guzzle installed so it's a pretty good solution for minimal requirements :) That said I wouldn't recommend to replace all your clients by it, it's for very specific usages. |
Changed log