Preparing release. #1355
Merged
Preparing release. #1355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Narsil
commented
Oct 6, 2023
| .flat_map(|i| { | ||
| let w = &words[*i] as *const _ as *mut _; | ||
| .flat_map(|&i| { | ||
| let word = &words[i] as *const _ as *mut Word; |
There was a problem hiding this comment.
@ArthurZucker Let's keep track of this. The newer compiler raised the casting of &Word to &mut Word as undefined behavior (meaning they can break it whenever they want).
Here I'm just keeping the raw pointer instead which works. But maybe things start breaking from this at some point.
|
The documentation is not available anymore as the PR was closed or merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.