feat: add SchedulerV3 #1996
Merged
feat: add SchedulerV3 #1996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
OlivierDehaene
commented
Jun 3, 2024
•
OlivierDehaene
commented
- Refactor code to allow supporting multiple versions of the generate.proto at the same time
- Add v3/generate.proto (ISO to generate.proto for now but allow for future changes without impacting v2 backends)
- Add Schedule trait to abstract queuing and batching mechanisms that will be different in the future
- Add SchedulerV2/V3 impl
OlivierDehaene
force-pushed
the
feat/generate_v3
branch
from
7007390
to
8a820d8
Compare
Narsil
reviewed
Jun 4, 2024
| message Input { | ||
| repeated InputChunk chunks = 1; | ||
| } | ||
|
|
||
| enum GrammarType { | ||
| GRAMMAR_TYPE_NONE = 0; | ||
| GRAMMAR_TYPE_JSON = 1; |
There was a problem hiding this comment.
Shouldn't this be moved to v2 ?
There was a problem hiding this comment.
No I added it to v3 directly to avoid any changes to v2.
There was a problem hiding this comment.
I meant the file generate.proto
Narsil
reviewed
Jun 4, 2024
|
|
||
| (scheduler, health_ext, shard_info, max_batch_total_tokens) | ||
| } | ||
| Err(_) => { |
There was a problem hiding this comment.
What kind of error does connecting a v3 client to a v2 shard create ?
There was a problem hiding this comment.
ClientError::Connection("Server does not support v3 interface".to_string())
5 tasks
yuanwu2017
pushed a commit
to yuanwu2017/tgi-gaudi
that referenced
this pull request
Sep 26, 2024
- Refactor code to allow supporting multiple versions of the generate.proto at the same time - Add v3/generate.proto (ISO to generate.proto for now but allow for future changes without impacting v2 backends) - Add Schedule trait to abstract queuing and batching mechanisms that will be different in the future - Add SchedulerV2/V3 impl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.