Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add vlm docs and simple examples #1812

Merged
merged 7 commits into from
Apr 30, 2024
Merged

feat: add vlm docs and simple examples #1812

merged 7 commits into from
Apr 30, 2024

Conversation

drbh
Copy link
Collaborator

@drbh drbh commented Apr 26, 2024

This PR start to add documentation for visual language models

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Contributor

@merveenoyan merveenoyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!
I think one very major thing is that this isn't a conceptual guide, it should be somewhere else. we tend to explain small cherry on top more theoretical concepts in conceptual guides

docs/source/conceptual/visual_language_models.md Outdated Show resolved Hide resolved
docs/source/conceptual/visual_language_models.md Outdated Show resolved Hide resolved
docs/source/conceptual/visual_language_models.md Outdated Show resolved Hide resolved
docs/source/conceptual/visual_language_models.md Outdated Show resolved Hide resolved
docs/source/conceptual/visual_language_models.md Outdated Show resolved Hide resolved
docs/source/conceptual/visual_language_models.md Outdated Show resolved Hide resolved
docs/source/conceptual/visual_language_models.md Outdated Show resolved Hide resolved
docs/source/conceptual/visual_language_models.md Outdated Show resolved Hide resolved
docs/source/conceptual/visual_language_models.md Outdated Show resolved Hide resolved
docs/source/conceptual/visual_language_models.md Outdated Show resolved Hide resolved
@drbh drbh marked this pull request as ready for review April 29, 2024 20:23
@drbh
Copy link
Collaborator Author

drbh commented Apr 29, 2024

hi @merveenoyan thank you for the review 🙏 I've moved the doc into the tutorial section and addressed your comments above.

Please let me know if I should make any more changes!

@Narsil Narsil merged commit b2c9827 into main Apr 30, 2024
2 checks passed
@Narsil Narsil deleted the add-vlm-docs branch April 30, 2024 10:14
Nilabhra pushed a commit to TII-AI-Research-Center/text-generation-inference that referenced this pull request May 14, 2024
This PR start to add documentation for visual language models
kdamaszk pushed a commit to kdamaszk/tgi-gaudi that referenced this pull request Jun 10, 2024
This PR start to add documentation for visual language models
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants