Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing stop parameter for chat request #1619

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Conversation

drbh
Copy link
Collaborator

@drbh drbh commented Mar 1, 2024

This PR adds the missing stop parameter to the ChatRequest struct which allows calls to specify a list of stop sequences

Copy link
Member

@philschmid philschmid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thank you for adding

@drbh drbh merged commit 7e08751 into main Mar 1, 2024
4 of 5 checks passed
@drbh drbh deleted the add-stop-to-chat branch March 1, 2024 17:08
kdamaszk pushed a commit to kdamaszk/tgi-gaudi that referenced this pull request Apr 29, 2024
This PR adds the missing `stop` parameter to the `ChatRequest` struct
which allows calls to specify a list of stop sequences
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants