-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add BetterTransformer support for RemBERT #545
Add BetterTransformer support for RemBERT #545
Conversation
The documentation is not available anymore as the PR was closed or merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for adding BetterTransformer
support for RemBERT
🎉
Very clean PR! Thanks also for taking care of the alphabetical order on the testing suite
Looking forward to your next contributions 💪
Hi @younesbelkada or @michaelbenayoun, I see that "first-time contributor needs a maintainer to approve running workflows". Could you help to approve that? Thanks! |
Thanks for the heads-up! Just run the workflow and we'll merge once it's green |
Hi @younesbelkada, there are two checks failed. 1/
I think it's either PyTorch's issue or sth has to be changed in 2/ ONNX Runtime - I saw this test has been failing on main branch. Since this is completely irrelevant to the code changes in this PR, can we ignore it for merging this PR? |
Hi @hchings |
Ok the test was just flaky, let's merge! |
What does this PR do?
Add BetterTransformer support for RemBERT (part of #20372)
Before submitting
[ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).Details
BertLayerBetterTransformer
. (please correct me if I'm wrong)cc @younesbelkada, @michaelbenayoun, @fxmarty. Thanks.