Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix NormalizedConfig init error message #500

Merged
merged 1 commit into from
Nov 22, 2022
Merged

fix NormalizedConfig init error message #500

merged 1 commit into from
Nov 22, 2022

Conversation

PaulQbFeng
Copy link
Contributor

What does this PR do?

The error message displayed was incomplete. With this addition, the user is reminded that by setting allow_new=True, a new attribute can be added.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Nov 22, 2022 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

@michaelbenayoun michaelbenayoun merged commit d0c0b5e into huggingface:main Nov 22, 2022
@JingyaHuang
Copy link
Collaborator

Thanks for completing the error message! @PaulQbFeng

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelbenayoun michaelbenayoun Awaiting requested review from michaelbenayoun

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PaulQbFeng @HuggingFaceDocBuilderDev @JingyaHuang @michaelbenayoun