Read use_external_data_format from ORTConfig file #1917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
Thanks @idruker-cerence |
When quantizing the models >2Gb, it's important to set the flag use_external_data_format to 'true', since otherwise the quantization will fail due to `ValueError: Message onnx.ModelProto exceeds maximum protobuf size of 2GB` However, currently there is no way to set the parameter when using optimum-cli because there is no such command option. Theoretically, it could be set when using ORTConfig file with -c comman flag, because one of the configuration parameters in it is use_external_data_format. In fact, the optimum code ignores it and does not pass it in quantize() function. The goal of this change is to close this gap.
idruker-cerence
force-pushed
the
use_external_data_format
branch
from
3d3f898
to
b059e1a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When quantizing the models >2Gb, it's important to set the flag use_external_data_format to 'true',
since otherwise the quantization will fail due to
ValueError: Message onnx.ModelProto exceeds maximum protobuf size of 2GBHowever, currently there is no way to set the parameter when using optimum-cli because there is no such
command option. Theoretically, it could be set when using ORTConfig file with -c comman flag, because one of the configuration parameters in it is use_external_data_format. In fact, the optimum code ignores it and does not pass it in quantize() function.
The goal of this change is to close this gap.
What does this PR do?
Fixes #1916
Before submitting
Who can review?