Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove read token #1903

Merged
merged 4 commits into from
Jun 14, 2024
Merged

Remove read token #1903

merged 4 commits into from
Jun 14, 2024

Conversation

fxmarty
Copy link
Contributor

@fxmarty fxmarty commented Jun 10, 2024

As per title

@fxmarty fxmarty requested a review from McPatate June 10, 2024 08:05
Copy link
Member

@McPatate McPatate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit, but lgtm otherwise

.github/workflows/test_onnxruntime.yml Outdated Show resolved Hide resolved
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@fxmarty fxmarty merged commit f480930 into main Jun 14, 2024
45 of 47 checks passed
@fxmarty fxmarty deleted the remove-read-token branch June 14, 2024 14:33
@@ -938,11 +938,14 @@ def test_stable_diffusion_model_on_rocm_ep_str(self):
self.assertListEqual(model.providers, ["ROCMExecutionProvider", "CPUExecutionProvider"])

def test_load_model_from_hub_private(self):
subprocess.run("huggingface-cli logout", shell=True)
# Read token of fxmartyclone (dummy user).
token = "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"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you revoked this token @fxmarty ? (I imagine that yes but just to make sure)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants