Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix FX CI #1866

Merged
merged 3 commits into from
May 27, 2024
Merged

Fix FX CI #1866

merged 3 commits into from
May 27, 2024

Conversation

IlyasMoutawwakil
Copy link
Member

What does this PR do?

Fixes CI failures

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

Who can review?

@IlyasMoutawwakil IlyasMoutawwakil changed the title Fix FX passes call to _gen_constructor_wrapper Fix FX passes May 22, 2024
@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

echarlaix
echarlaix approved these changes May 23, 2024
View reviewed changes
Copy link
Collaborator

@echarlaix echarlaix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the fix @IlyasMoutawwakil

optimum/fx/optimization/transformations.py Outdated Show resolved Hide resolved
@IlyasMoutawwakil IlyasMoutawwakil changed the title Fix FX passes Fix FX CI May 25, 2024
@echarlaix echarlaix merged commit d2fade2 into main May 27, 2024
41 of 48 checks passed
@echarlaix echarlaix deleted the fix-fx-passes branch May 27, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelbenayoun michaelbenayoun michaelbenayoun approved these changes

@echarlaix echarlaix echarlaix approved these changes

@fxmarty fxmarty Awaiting requested review from fxmarty

@mht-sharma mht-sharma Awaiting requested review from mht-sharma

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@IlyasMoutawwakil @HuggingFaceDocBuilderDev @michaelbenayoun @echarlaix