Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds MPNet to NormalizedConfig and ORTConfigManager #1471

Merged
merged 3 commits into from
Feb 29, 2024

Conversation

nathan-az
Copy link
Contributor

What does this PR do?

Adds optimiser support for MPT

Fixes #1433

I don't believe this PR requires any tests, and the documentation already states that MPT is supported so I assume this is an oversight. Happy to make any requested changes!

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

@nathan-az nathan-az changed the title Adds mpnet to ORTConfigManager and NormalizedConfigManager Adds MPNet to optimiser support Oct 20, 2023
@nathan-az nathan-az changed the title Adds MPNet to optimiser support Adds MPNet to NormalizedConfig and ORT config manager Oct 27, 2023
@nathan-az nathan-az changed the title Adds MPNet to NormalizedConfig and ORT config manager Adds MPNet to NormalizedConfig and ORTConfigManager Oct 27, 2023
@vrdn-23
Copy link
Contributor

vrdn-23 commented Feb 27, 2024

@fxmarty Is this an acceptable fix for the issue mentioned? I can see that MPNet has been crossed off as one of the models supported in #555 but I'm not sure if that's accurate

@fxmarty
Copy link
Contributor

fxmarty commented Feb 29, 2024

@vrdn-23 @nathan-az Apology for the delay, I missed this PR. Yes, it looks good to me.

#555 was only about the ONNX export.

Copy link
Contributor

@fxmarty fxmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fxmarty fxmarty merged commit 64f795d into huggingface:main Feb 29, 2024
38 of 45 checks passed
young-developer pushed a commit to young-developer/optimum that referenced this pull request May 10, 2024
Adds mpnet to ORTConfigManager and NormalizedConfigManager

Co-authored-by: fxmarty <9808326+fxmarty@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support MPNet model in NormalizedConfig and ORTOptimizer
3 participants