Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor prefill and inference benchmark #184

Merged
merged 15 commits into from
Apr 14, 2024
Merged

Conversation

IlyasMoutawwakil
Copy link
Member

@IlyasMoutawwakil IlyasMoutawwakil commented Apr 14, 2024

  • fixes the issue of incompatible inputs between forward and generate passes by using generate for prefill.
  • updates how we measure the processed volume (tokens/images/samples); taking into consideration cases where a text generation task takes other modalities as input.
  • added an iterations argument to allow explicitly setting a minimum number of iterations a benchmark should perform; benchmark ends when both duration and iterations constraints are satisfied.

@IlyasMoutawwakil IlyasMoutawwakil changed the title Refactor prefill and volume counting Refactor prefill and inference benchmark Apr 14, 2024
@IlyasMoutawwakil IlyasMoutawwakil merged commit 6913d23 into main Apr 14, 2024
20 checks passed
@IlyasMoutawwakil IlyasMoutawwakil deleted the refactor-prefill branch May 17, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant