Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type mismatch error, add tests for negative prompts #823

Merged
merged 1 commit into from
Oct 13, 2022

Conversation

anton-l
Copy link
Member

@anton-l anton-l commented Oct 13, 2022

  • Makes sure that prompts are not wrapped in a list too soon (causing type(prompt) is not type(negative_prompt))
  • Adds fast tests for negative prompts in SD pipelines

Fixes #820

@@ -195,7 +195,6 @@ def __call__(
"""
if isinstance(prompt, str):
batch_size = 1
prompt = [prompt]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the cause of the error in #820

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Oct 13, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Contributor

@patil-suraj patil-suraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks a lot for fixing this!

Copy link
Contributor

@patrickvonplaten patrickvonplaten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super nice tests - thanks a lot!

@anton-l anton-l merged commit 26c7df5 into main Oct 13, 2022
@anton-l anton-l deleted the test-neg-prompts branch October 13, 2022 13:45
@patrickvonplaten patrickvonplaten mentioned this pull request Oct 14, 2022
6 tasks
prathikr pushed a commit to prathikr/diffusers that referenced this pull request Oct 26, 2022
yoonseokjin pushed a commit to yoonseokjin/diffusers that referenced this pull request Dec 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pull request #793 broke negative prompts for IMG2IMG pipeline
4 participants