Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add token and char count to histogram stats #251

Merged
merged 3 commits into from
Jul 15, 2024
Merged

Conversation

guipenedo
Copy link
Collaborator

Adds 2 new stats per original stat when histogram stats are collected:

  • originalname__chars: number of chars
  • originalname__tokens: number of tokens (if metadata["token_count"] is defined)

Copy link
Contributor

@hynky1999 hynky1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@guipenedo guipenedo merged commit 452e69a into main Jul 15, 2024
5 checks passed
@guipenedo guipenedo deleted the hist_token_counts branch July 15, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants