Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

status code: input parsing, no EnvironmentError case handling #460

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

oOraph
Copy link
Collaborator

@oOraph oOraph commented Oct 7, 2024

example:
task: image-to-image
if the user provides sth that cannot be parsed by PIL (eg an image) PIL will raise an OSError (and EnvironmentError is an alias for OSError, kept for backward compat) But actually this "OSError" is due to some bad payload provided by the user. So let's consider that we have filtered all internal errors when loading pipeline

example:
task: image-to-image
if the user provides sth that cannot be parsed by PIL (eg an image)
PIL will raise an OSError (and EnvironmentError is an alias for OSError, kept for backward compat)
But actually this "OSError" is due to some bad payload provided by the user.
So let's consider that we have filtered all internal errors when loading pipeline

Signed-off-by: Raphael Glon <oOraph@users.noreply.github.com>
@oOraph oOraph requested a review from Narsil October 7, 2024 13:55
@oOraph oOraph marked this pull request as ready for review October 7, 2024 14:01
@oOraph oOraph merged commit 86a35d0 into main Oct 7, 2024
2 checks passed
@oOraph oOraph deleted the dev/status_code branch October 7, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants