Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The .upignore should not tell the IDE to actually ignore files #483

Closed
3 tasks done
polothy opened this issue Oct 3, 2017 · 3 comments
Closed
3 tasks done

The .upignore should not tell the IDE to actually ignore files #483

polothy opened this issue Oct 3, 2017 · 3 comments

Comments

@polothy
Copy link

polothy commented Oct 3, 2017

Prerequisites

  • Plugin is in the latest version
  • Issue was not reported yet
  • Stack trace (if provided) contains mobi.hsz.idea.gitignore package name

Description

The .upignore should not tell Intellij to actually ignore files. While the contents behave like a .gitignore file, it is not meant to actually ignore files in the editor. It is used to provide a whitelist or blacklist of files to include in the build zip. Example contents from the docs:

*
!app.js
!package.json
!node_modules/**
!src/**

So, this would ignore all docs, README, etc, when building the zip asset, but it shouldn't tell the IDE to ignore those files as well.

Steps to Reproduce

I was using PHPStorm.

  1. Create an .upignore
  2. While editing the .upignore, get benefits from plugin this regarding paths, etc.

Expected behavior: What you expect to happen

The paths in .upignore do not cause the editor to actually ignore files. Ideally, you can still apply the benefits of this plugin to the editing of the .upignore files. But, if it is all or nothing, I suggest revert supporting this file.

Actual behavior: What actually happens

The paths in .upignore cause the editor to ignore files. You then get notifications about editing an ignored file.

Reproduces how often: What percentage of the time does it reproduce?

100%

Versions

Plugin:

2.2.1

IDE:

PHPStorm 2017.2.4

OS:

macOS Sierra 10.12.6

@hsz hsz added this to the v2.2.2 milestone Oct 11, 2017
@hsz hsz added the bug label Oct 11, 2017
@hsz
Copy link
Member

hsz commented Oct 11, 2017

@mrmark Thank you for this report. It's fixed and will be released with v2.2.2

@polothy
Copy link
Author

polothy commented Oct 11, 2017

Awesome, thanks so much for you time!

@hsz
Copy link
Member

hsz commented Oct 12, 2017

Fix has been published with v2.2.2.

@hsz hsz closed this as completed Oct 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants