Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File type for .dockerignore should not be named 'Docker' #375

Closed
borlander opened this issue Jun 20, 2017 · 2 comments
Closed

File type for .dockerignore should not be named 'Docker' #375

borlander opened this issue Jun 20, 2017 · 2 comments

Comments

@borlander
Copy link

Extracted from https://youtrack.jetbrains.com/issue/IDEA-174706

Actually the filetype for .dockerignore files is named Docker in UI.
See attached screenshot showing 2 competing same-named Docker entries.

screen shot 2017-06-20 at 13 51 45

The black icon is from ignore plugin while "with-D" icon is from the Docker support plugin.
The fact that the black-whale icon is actually much nicer :) probably only contributes to the confusion of the users.

In addition to UI name, the key used to store the filetype association is actually also "Docker file" which is again competing with the official Docker support plugin, see the following extract from /options/filetype.xml file:

<application>
  <component name="FileTypeManager" version="17">
    <extensionMap>
      <mapping ext="custom-dockerignore" type="Docker file" />
      <mapping pattern="custom-docker-file" type="Dockerfile" />

The latter (the key in the options file) is more difficult to change, but UI name should be easy to fix.
Thanks

@hsz hsz added this to the v2.0 milestone Jun 20, 2017
@hsz
Copy link
Member

hsz commented Jun 20, 2017

@borlander Thanks for this ticket. I agree with you that people can be confused with the very simmilar name.

I'll refactor those names (not only Docker but all the other file types too) and publish it with v2.0.0

@hsz
Copy link
Member

hsz commented Jul 3, 2017

@borlander Ok, I've updated the displayed name of the ignore-file types. Currently it looks like:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants