Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid "found ignored files included in git" #350

Closed
zeg-io opened this issue Mar 23, 2017 · 4 comments
Closed

Invalid "found ignored files included in git" #350

zeg-io opened this issue Mar 23, 2017 · 4 comments

Comments

@zeg-io
Copy link

zeg-io commented Mar 23, 2017

I have a project with a "temp directory" which I want to include but NOT include any files within it EXCEPT for .gitinclude file. (so it preserves the directory)

So my .gitignore looks like this:

#Ensure the files directory is included, but not the contents
tempFiles
!.gitinclude

/tempFiles
-> .gitinclude
-> otherTempFile.xml
-> otherTempFile.xml
-> otherTempFile.xml

However, the plugin is erroneously thinking that .gitinclude is supposed to be ignored rather than specifically un-ingnored

@cviebrock
Copy link

Same here, with this structure:

/storage
  /cache
    .gitignore

And this .gitignore file:

*
!.gitignore

@islemaster
Copy link

The plugin also doesn't take into account that a checked-in .gitignore file doesn't ignore itself:

/temp
  .gitignore

Where .gitignore is simply:

*

Git still picks up changes to this file.

@FrancYescO
Copy link

Confirming, this is happening from the last release

@hsz
Copy link
Member

hsz commented May 31, 2017

@zeg-io @cviebrock @islemaster @FrancYescO

Thank you for this report. I have fixed both (excluding files with ! and a case with *) issues. They will be delivered with the next v2.0.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants