Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Generate without comment" option #229

Closed
Muyangmin opened this issue May 25, 2016 · 2 comments
Closed

Add "Generate without comment" option #229

Muyangmin opened this issue May 25, 2016 · 2 comments
Milestone

Comments

@Muyangmin
Copy link

Thanks for this awesome plugin!
Sometimes we want to make .gitignore file to be as simple and clear as possible, so is this worth to add such an option on generate?
In my opinion, comments for each ignore rule becomes redundant when everyone knows why ignore those files.

@hsz
Copy link
Member

hsz commented May 25, 2016

@mathben Thank you for this suggestion - it's worth implementing. 👍

What do you think - how should it be presented to the user ? Another option in the Generate button expanded list ?

Should it be also somehow combined with Generate without duplicates ?

Maybe some additional refactoring options ? If so - how it should work ? I'm open for the new ideas !

@Muyangmin
Copy link
Author

Hmm……I'm also confused for this question. I've already think about a checkbox before Generate Button so it can be obvious and easily combined with without duplicates option. But if we add more generate option, this combination maybe quickly grows to very duplicated.
From my original simple idea, maybe a totally clean ignore file is enough for who want to use this feature. So maybe another Generate button in expanded list is enough. (Of course, I don't mind if other users have better ideas!)

@hsz hsz added this to the 1.5 milestone Jun 11, 2016
@hsz hsz closed this as completed Jun 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants