"is covered by" is wrong

[mnpenner]

Running version 1.4.1 now.

This warning is giving false positives:

~$ is not covered by (?<![^/])\. nor ^node_modules/.

Most of those "entry is never used" warnings are wrong too actually.

[jwfearn]

Here's another one I found:

[hsz]

@mnpenner @jwfearn

Those rules are marked as covered because the rule that is marked as covering those subrules.

For example ~$ matches some files that ends with ~ character but they are located under the node_modules directory and nowhere else.

If you'll create some template foo~ file in the root directory - it will not be matched as covered by ^node_modules/ directory.

Can you please verify it ?

[mnpenner]

I created a new file called derp~ inside the root of my project directory, and that warning did indeed go away. However, I then moved the file into another ignored directory, and the warning did not re-appear to tell me it was covered by the other directory. Lastly, I removed ^node_modules/ and ~$ from my .hignore and then did hg st | grep '~' to see what files were being covered, and there does not appear to be any ~ files in my node_modules directory. find . -name *~ only finds my one derp~ file too, so I don't think I have any other ~ files. If that's the case, how can ^node_modules/ be covering it?

[Alexsey]

[hsz]

Can I ask you to check if this issue is still present in v2.1.1?

[Alexsey]

[mnpenner]

I don't seem to have any "is covered by" warnings anymore, but I have a lot of incorrect "entry is never used" warnings, which I've verified by removing the line and running hg stat again. The number of untracked files changes, so these rules are definitely doing something.

[charlwillia6]

Every single line for me says "entry is never used." This is in Rider 2017.2 EAP. My .gitignore file is in the root of my project. My project structure looks like:

|-- .git
|-- Help
|-- src
-- .gitattributes
-- .gitignore
-- Docs.shfbproj
-- README.md

I used direct paths to some directories and files, so there really is no reason for it.

[toolforger]

@mnpenner find . -name *~ does not do what you think it does, because the *~ will be interpreted by the shell, not by find.
You should say find . -name "*~" instead.

[mnpenner]

@toolforger Thanks. That does indeed turn up a whole bunch of files under node_modules but it doesn't explain why this plugin thinks the ~$ rule is unused. Adding and removing that line from .hgignore changes the output of hg stat, so one way or another, it's used.

[hsz]

Fixed and released with v3.1.1