-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gitignore scan .gitignore file in ver 1.3 #204
Comments
Same here. |
@lovehcf-duplicate @alxbauer Thanks for the quick report. Can you provide me more information about the Project configuration - i.e. submodules, gitignore content, etc - I'll fix it asap. |
Also having this issue with a larger codebase. Notable: when opening module directories for the first time after (re)starting the IDE - it takes a couple seconds and my network traffic spikes. |
@awerment I do not use any network in my plugin, so it's a different reason of this peak. |
Thanks for the super quick reply. Unfortunately this is a closed internal project. I'm running IntelliJ Ultimate 2016.1, 64bit on Win8. The project layout is quite chaotic, basically it's one parent module which contains sub-directories - one of which is a nested maven module structure. The other directories contain former eclipse projects (we're migrating, don't ask...), they are not managed as modules in IntelliJ. After going through some of the old projects, I noticed they themselves contained .gitignore files. After removing them (only one remains for the parent directory), the IDE is usable. But the root issue still seems to remain - opening any module folders for the first time takes longer than it does without the plugin enabled. The network spikes also remain, not sure what's the cause there. |
I also have same problem after upgrade to v1.3. It cause open floder slow and also make right click menu show slow |
Same problem here, I think. Opening pretty much any full Drupal website in PhpStorm is causing the task "Indexing ignore files" to take several minutes, during which time my IDE is almost completely unresponsive. After the process completes, then the IDE remains very slow and unresponsive for at least 30 seconds more. Finally, after that it seems to work more quickly, though taking any number of actions, such as attempting to commit code to Git, seems to cause the UI to go unresponsive again for several seconds. This was not an issue at all until the update I just installed to 1.3 today. |
I am experiencing the performance impact too after upgrading to 1.3. WebStorm becomes very slow to be usable. Disabling the plugin regains the performance. |
After updating to 1.3 I also emergence of this issue, the project configuration without any changes. Every time you open phpstorm scans items in all .gitignore, then scanned the entire phpstorm reaction becomes very slow, and then pull the situation becomes more serious |
Same as @bmcclure here. |
@hsz |
@hsz I'm so sorry,unable to install the plugin.Install the plugin from disk and then restart IDE(Android Studio),the widget disappear. |
@hsz I am having the same issue. The plugin disappear from the list after restarting WebStorm |
the same problem as @lovehcf-duplicate |
@z5864703 @lovehcf-duplicate @pswai @VanDalkvist Have you unzip this file before and install idea-gitignore.jar file ? |
@hsz Installing the jar works! But it gives this error after restarting
|
@pswai Ok, please ignore this error for the moment - what about the performance ? |
@hsz Thank you for reminding,the jar works. |
@hsz Much better. Now it won't make WebStorm completely unusable but the lagginess is still there. I have tried to enable/disable it several times and I can feel the difference. It is especially noticeable when using Go To File function, the autocomplete is lagging with small freeze sometimes. |
Having the same issue, even with the attached jar, PhpStorm 2016.1 on Win 8.1 with Laravel Project. After it's done with the indexing there is a significant lag with just typing/code completion and just about everything else. Phpstorm idle (after indexing) cpu usage is ~6% with the plugin enabled and 0% with it disabled. Tried to downgrade to 1.2, but get an error
|
I also am experiencing this. Just updated and PhpStorm just crawls, disabling this plugin and its back to being lightning fast. Really hope this can get resolved, I do enjoy this plugin. |
I now experience this slowdown with version 1.3.1 of the plugin. The symptoms are the same as in the opening post: loading icon for every .gitignore in the project and massive CPU load. I didn't get this problem before. Not sure what version I had installed, I think it was 1.3.0 that was working fine for me. Disabling the plugin fixed the issue. |
I've updated the plugin to version 1.3.1 this morning (linux ubuntu machine) and phpstorm went painfully slow. After disabling the plugin everything worked as before. |
Can you guys provide me more information about it ? What is the project structure, how mony ignore files do you have (in subfolders too) ? What is the content of the main Do you have any public project, so I could fetch it ? I'll try to get as much information as I can and deliver the fix today. |
https://github.com/primeinc/csg-sam is the project I've been working on that has the problems described. |
In my case it's a company internal project. Sorry, no public respositories. A "find . -type f -name ".gitignore" | wc -l" points out a number of 68. The main .gitgnore looks like this:
|
@Suseika I hadn't tried, but unfortunately yes, the problem reappears |
@azeos , should I Invalidate Caches for all project? because I have more than 10 projects. |
@Viky-zhang The problem reappears after you close and open again the application. So, disabling the plugin is the only -apparent- solution. Try that first and may be you don't need to invalidate the caches. |
Thank you everyone for the support. I've prepared a fixed version, but before pushing it to the JetBrains repository, I'd like to ask you if you can verify it and confirm that none of above issues appears again. |
@hsz Settings -> Plugins -> Install plugin from disk -> idea-gitignore-1.3.1-2040257.jar and I get "Plugin '.ignore' is incompatible with this installation". PhpStorm 2016.1 x64 @ Win7 x64. |
@azeos Same here. IDEA IC-145.257 x86_64, Debian |
Ok, sorry about that - gradle plugin by default limits the IDE versions. Please install following package (without unzipping - select zip file - this one is 'jar-less' package). Thanks ! |
@hsz I installed the plugin and restarted the IDE. After it reloaded, I had a massive responsiveness degradation in the IDE with high CPU usage, but without the series of messages notifying that .gitignore files are being processed. After some time the slowdown ended. Then I restarted the IDE, and the same temporary slowdown appears for several minutes after starting. So the only thing that has changed is that now it doesn't show me the notifications attached in the opening post. |
@Suseika I have checked my plugin with profiler tool and it takes just a few % of CPU at the startup so I bet it's not a really caused by the .ignore plugin. Can you post a CPU snapshot ? |
@hsz Sorry, I can't:
|
@hsz Can you clone the repository I posted above and try to load it in IDEA with the plugin enabled to see if you get any slowdown at startup? The repository has all the necessary project files for IDEA. Make sure to pull all the submodules. |
https://drive.google.com/file/d/0B-3lG2AWxus5SFV3TDVjTWdvUFE/view?usp=sharing I've attached two snapshots, first one is without the plugin enabled. Maybe a misconfig is calling I don't have a global exclude file setup. |
Confirmed Windows workaround:
Probable? *nix workaround:
All performance issues go away, at least with |
@primeinc That was a bull's-eye. I've prepared a fix. Can you confirm that it fixes the issue? idea-gitignore-1.3.1-4041002.zip
|
@hsz this fix seems fine |
yep I ran |
@primeinc That's a good news! Thank you again for the help in this case. What about the others? Do you also can confirm the performance improvement? |
thumbs-up Look good! |
In PhpStorm 2016.1. Look good ! |
@hsz Thanks for the fix! |
Hi, everytime I open my idea integrated .ignore both to scan all moudles' .gitignore file,lead to my ide too broken and unable to work;At the same time waiting for a long time to unfold the moudle's src etc.
Thanks.
The text was updated successfully, but these errors were encountered: