Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cancelling the creation of a gitignore file still creates the file #156

Closed
stof opened this issue Aug 4, 2015 · 1 comment
Closed

Cancelling the creation of a gitignore file still creates the file #156

stof opened this issue Aug 4, 2015 · 1 comment
Labels
enhancement
Milestone
1.2

Comments

@stof
Copy link
Contributor

stof commented Aug 4, 2015

No description provided.

@hsz hsz added this to the 1.2 milestone Aug 10, 2015
hsz added a commit that referenced this issue Aug 10, 2015
@hsz
#156 Prevent ignore file creation when dialog generator is canceled
84d1fc4
@hsz hsz closed this as completed Aug 10, 2015
@hsz
Copy link
Member

hsz commented Aug 10, 2015

@stof Thanks for reporting. This was expected behaviour because you are creating the ignore file anyway and canceling just the Ignore File Generator step.
However it's better to abort whole process when canceling the dialog.

It'll be avaliable with the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
1.2
Development

No branches or pull requests
2 participants
@hsz @stof