Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A bug in generating lag features #3

Open
anhquan0412 opened this issue Feb 8, 2018 · 1 comment
Open

A bug in generating lag features #3

anhquan0412 opened this issue Feb 8, 2018 · 1 comment

Comments

@anhquan0412
Copy link

There is a bug in week 4 programming assignment notebook where you generate lag features
'After creating a grid, we can calculate some features. We will use lags from [1, 2, 3, 4, 5, 12] months ago.'

The lag features are correct for only target_lag_{} (target_lag_1,2,3 ...) and incorrect for any other lag features.

I documented that bug and the fix in here. Fixing this bug helps me boost my score in LB tremendously.
https://gist.github.com/anhquan0412/330494b051f74eacad3917f43e3ba43a

@aguschin
Copy link
Member

Great! Thank you for finding this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants