Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mislabeling of section in compute_KNN_features #23

Open
alecalma opened this issue Sep 3, 2020 · 0 comments
Open

Mislabeling of section in compute_KNN_features #23

alecalma opened this issue Sep 3, 2020 · 0 comments

Comments

@alecalma
Copy link

alecalma commented Sep 3, 2020

Hi,

in compute_KNN_features, honours assignment week 4, inside get_features_for_one, it says:

"2. Same label streak: the largest number N, such that N nearest neighbours have the same label."

I find the task label to be very misleading. Literally it means to check the max number of neighbours within the array with the same label. I would reformulate the task label as:

"2. Same label streak: the largest number N, such that the first N nearest neighbours have the same label."

I hope you can understand my point.

Thanks for the great course!

Alessandro

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant