Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ch-run: don’t mount user home by default #1470

Closed
j-ogas opened this issue Oct 17, 2022 · 1 comment · Fixed by #1506
Closed

ch-run: don’t mount user home by default #1470

j-ogas opened this issue Oct 17, 2022 · 1 comment · Fixed by #1506
Assignees
Milestone

Comments

@j-ogas
Copy link
Contributor

j-ogas commented Oct 17, 2022

Remove user home directory from default binds. Make --no-home default behavior and replace it with, --home, a convenience argument that binds the user home directory.

Unlike the other default binds, the user's home directory:

  1. isn't required for functionality or hardware visibility; rather, it is primarily included for convenience, e.g., dotfiles for interactive sessions; and
  2. can cause obscure, unintended runtime behavior when dotfiles manipulate environment variables like PATH, PYTHONHOME, MPI_HOME, etc.

Default binds should not have unintended run time consequences.

@reidpr reidpr self-assigned this Dec 7, 2022
@reidpr reidpr added this to the 0.31 milestone Dec 7, 2022
@reidpr reidpr changed the title ch-run: default bind: remove user home ch-run: don’t mount user home by default Dec 7, 2022
@qwofford
Copy link

qwofford commented Dec 8, 2022

This caught my attention. After reading the issue description, I agree with the logic. I vote for a big obvious announcement on version release! In bold! With colors! @azukaitis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants