Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated algorithm to split aoi when no linear features #31

Merged
merged 10 commits into from
Jun 5, 2024

Conversation

Sujanadh
Copy link
Contributor

@Sujanadh Sujanadh commented May 21, 2024

Changes

  • refactored existing algorithm to allow splitting the aoi when no linear features are present by clustering according to the number of buildings used
  • used k-means clustering

Issue

@Sujanadh
Copy link
Contributor Author

  • looking for other issues to solve

@Sujanadh Sujanadh marked this pull request as draft May 21, 2024 04:11
@Sujanadh
Copy link
Contributor Author

I think i overdid the clustering twice, so removed it.

@Sujanadh
Copy link
Contributor Author

  • simplified the task boundaries; related to #1151
  • removed hardcoded buildings number

@Sujanadh
Copy link
Contributor Author

@Sujanadh Sujanadh marked this pull request as ready for review May 28, 2024 10:58
@spwoodcock
Copy link
Member

This is excellent work.

I just fixed the tests.
The update also also appears to have fixed an issue where some task areas were generated as multipolygons (i.e. with holes) 👍
It mainly reduces the number of task areas generated, which is likely a good thing (as the buildings are better distributed amongst areas).

Merging 🎉

@spwoodcock spwoodcock merged commit 58947db into hotosm:main Jun 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependency Includes a dependency change
Projects
None yet
2 participants