Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature : Tile Thumbnail #289

Merged
merged 4 commits into from
Oct 15, 2024
Merged

Feature : Tile Thumbnail #289

merged 4 commits into from
Oct 15, 2024

Conversation

kshitijrajsharma
Copy link
Member

@kshitijrajsharma kshitijrajsharma commented Oct 8, 2024

What does this PR do ?

  • Adds tile information for models to be displayed in thumbnails

Consideration

I know this is not an ideal solution , currently it is grabbing the centroid from AOI which is tied to dataset , this is not great . I don't like this implementation but will do the job for now . Later I need to figure out how to do this best with some changes in the DB models possibly !

@kshitijrajsharma kshitijrajsharma marked this pull request as ready for review October 10, 2024 10:36
Copy link
Contributor

@omranlm omranlm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, I am gonna conduct another test when the API is on the dev env

@omranlm
Copy link
Contributor

omranlm commented Oct 10, 2024

We will need to visit this again to support other private TMS servers as well CC: @kshitijrajsharma

@kshitijrajsharma kshitijrajsharma merged commit 0497eea into develop Oct 15, 2024
2 checks passed
@kshitijrajsharma kshitijrajsharma deleted the feature/tile-thumbnail branch October 15, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants