-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new sort, pagination, spinner and checkbox functionality added to table component #5
feat: new sort, pagination, spinner and checkbox functionality added to table component #5
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please look into this comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
@JoelJacobStephen, I was wondering if we'd need to include search and pagination logic directly in the |
@jamesgeorge007 Search and pagination logic aren't implemented into the Table component. Only the UI is provided and events are emitted when the related UI elements are being used. The search and pagination logic will be handled by the parent component using the smart table by handling the events that are triggered from the UI component. I also went through few popular UI libraries and they have given support for pagination and search UI elements within their table component. I will replace the input element with HoppSmartInput. Thanks for the catch!! |
Discussed separately, the search element will be removed in the same PR, and moving the pagination element out into a separate component to be done in a later iteration. |
Implicitly conveyed via the `selectedRows` prop
61fccf6
to
dba62f1
Compare
PreviewScreen.Recording.2024-03-01.at.4.25.26.PM.mov |
Ticket
Closes HFE-418
Description
This PR adds new functionality to the Table UI component.
These include:
Checks