Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One /send command might result in multiple transactions when editing the original message #3

Open
CrsiX opened this issue Sep 22, 2020 · 1 comment
Labels
question Further information is requested

Comments

@CrsiX
Copy link
Member

CrsiX commented Sep 22, 2020

The user who performs a /send operation is able to edit the message of the /send command. This creates yet another Update object and therefore creates a new bot reply (confirmation dialog). Now, there are two open dialog messages. The original one and the edited one (maybe more when editing again...). Both of them have a CONFIRM and an ABORT button attached. When the user clicks on one of those buttons, only the text of the message the button belongs to will be edited accordingly. If the click is ABORT, everything is fine. But, however, it's becomes easily possible to click on CONFIRM more than once and send money to other users / with other amounts / with other descriptions without really wanting that.

Should we change this? Or is it the user's duty to read carefully what a message says and don't hit any button without thinking about it?

@CrsiX
Copy link
Member Author

CrsiX commented Nov 6, 2020

I have just checked for this issue right now. Actually, it's still possible to do it, but I don't think that this is a real bug. It's no problem in the software. A user should be sure about what he or she is doing.

I move this issue to the Advanced Features milestone and remove the bug label.

@CrsiX CrsiX transferred this issue from hopfenspace/MateBot Aug 13, 2021
@CrsiX CrsiX added the question Further information is requested label Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant